Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add ability to update devices of driver during build #86

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Dec 18, 2020

Nice to have posibility to update on docker image build time devices!

@coveralls
Copy link

coveralls commented Dec 18, 2020

Pull Request Test Coverage Report for Build 430653477

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.523%

Totals Coverage Status
Change from base Build 430569288: 0.0%
Covered Lines: 1931
Relevant Lines: 6914

💛 - Coveralls

@robertsLando
Copy link
Member

robertsLando commented Dec 18, 2020

@billiaz I think this is something that should be implemented on zwavejs side first. @AlCalzone I agree that this would be cool, but should we use npm update zwave-js@config for that or should we use another way?

@varet80
Copy link
Collaborator Author

varet80 commented Dec 18, 2020

@robertsLando i do not disagree, till then, having a docker file, able with an argument to update devices is nice feature
By default is disabled, u les you set a value on build argukent deviceUpdate.

@AlCalzone
Copy link
Member

I'm still planning to auto-update @zwave-js/config, but until that is implemented, I think we can do it during the build.

@varet80
Copy link
Collaborator Author

varet80 commented Dec 18, 2020

The change I propose is not documented well.

More details:

  • Following the normal build, without modifying any argument. It will build a container without updating the database
  • Adding a --build-arg updateDevices=on with any value instead of on it will trigger the cloning of the repository under the zwavejs argument
  • We can override the target repository by also adding the argument --build-arg zwavejs=<git endpoint>. This solves the reason I though of adding this option. I can this way Debug device additions without the need of compiling the zwave-js module.

I find it helpful for people (with or without implemented the auto-update happening through driver, to give the ability on people to participate in these projects.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit e7ad93b into master Dec 18, 2020
@robertsLando robertsLando deleted the feat#dockerDeviceUpdate branch December 18, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants