Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discovery issues caused by spaces in topic #99

Merged
merged 2 commits into from
Dec 21, 2020
Merged

fix: discovery issues caused by spaces in topic #99

merged 2 commits into from
Dec 21, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Dec 21, 2020 •
edited
Loading

Fixes #91 #60 #94

@robertsLando
Copy link
Member Author

@billiaz Check this

@coveralls
Copy link

coveralls commented Dec 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 435370440

  • 2 of 14 (14.29%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 28.535%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 2 14 14.29%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 3 20.07%
Totals Coverage Status
Change from base Build 435336432: 0.04%
Covered Lines: 1937
Relevant Lines: 6932
💛 - Coveralls

This was linked to issues Dec 21, 2020
[bug] Hass Discovery Motion Sensor & Cover Status name issues #60
Closed
[bug] 113-0-Access Control-Door state not sending MQTT message (spaces in topic?) #94
Closed
@robertsLando robertsLando mentioned this pull request Dec 21, 2020
Closed
@robertsLando
Copy link
Member Author

This is a breaking change for hass users, many entities will have a different unique id

@varet80
Copy link
Collaborator

varet80 commented Dec 21, 2020

tested works like charm

@robertsLando robertsLando merged commit 528a51c into master Dec 21, 2020
@robertsLando robertsLando deleted the fixDIscovery branch December 21, 2020 09:03
ahochsteger pushed a commit that referenced this pull request Dec 27, 2020
@robertsLando @ahochsteger
fix(hass): discovery issues caused by spaces in topic (#99)
852647d 
BREAKING CHANGE: Hass entities ids will change
Co-authored-by: V Aretakis <vassilis@aretakis.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@robertsLando @coveralls @varet80