Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protoSrcsDir config option #150

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

codersasha
Copy link

Add a new config option, protoSrcsDir, which optionally limits the scope of proto file searches from {workspaceRoot}/** down to {workspaceRoot}/path/to/protos/**. This fixes an issue where autocompletion and go-to-definition calls are unuseably slow (upwards of 30 seconds) in repos with large numbers of ignored files (e.g. node_modules, bazel-out). With this fix, they are instant.

The "proper" way to fix this would be to respect VSCode's existing ignore lists in settings.json, but I'm not sure how to do that with fastglob in a way that actually improves performance. So, this solves the issue for now :)

@Qtax
Copy link

Qtax commented Mar 18, 2024

Something like this is badly needed for our monorepo. Without it "go to definition" is extremely slow, taking 10-30 seconds. Even when the definition is in the same file. 😅

Greateapot added a commit to Greateapot/vscode-proto3 that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants