Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for the type HTMLVideoElement #530

Closed
wants to merge 2 commits into from
Closed

Fix check for the type HTMLVideoElement #530

wants to merge 2 commits into from

Conversation

ti777777
Copy link

No description provided.

@ti777777 ti777777 changed the title Fix check for type HTMLVideoElement Fix check for the type HTMLVideoElement Jul 29, 2022
@ti777777
Copy link
Author

ti777777 commented Jul 29, 2022 •
edited
Loading

fix #493 #497 #516 #520 #525

@ti777777 ti777777 marked this pull request as draft July 29, 2022 17:37
@ti777777 ti777777 marked this pull request as ready for review July 29, 2022 17:38
@ti777777
Copy link
Author

ti777777 commented Aug 8, 2022

Hi,
Does anybody can help to review this PR

@mageshk98
Copy link

mageshk98 commented Oct 11, 2022 •
edited
Loading

@mmalomo @ti777777 Any idea when this will be merged into the master?

@ti777777
Copy link
Author

@mmalomo @ti777777 Any idea when this will be merged into the master?

Sorry,I am not the maintainer. I have no idea.😅

@mageshk98 mageshk98 mentioned this pull request Dec 30, 2022
Open
@mageshk98
Copy link

A temporary hack worked for me.

const img = document.getElementById('img');
img.videoWidth = 0;
codeReader.decodeFromImage(img).then((result) => { //Logic goes here }

@drborges drborges mentioned this pull request Mar 10, 2023
Open
@werthdavid
Copy link
Member

Can u update the merge conflicts? I will then merge this!

werthdavid added a commit that referenced this pull request Apr 19, 2023
@werthdavid
#530 Fix check for the type HTMLVideoElement
fee0b07
@werthdavid werthdavid closed this Apr 19, 2023
@werthdavid
Copy link
Member

I fixed it directly on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalomo mmalomo mmalomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti777777 @mageshk98 @werthdavid @mmalomo