Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive approach to update to angular 17 #541

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Angelinsky7
Copy link
Contributor

it's a really naive approach to update to angular 17.
i only changed the angular version and updated the packages versions.
i tried to rebuild everything, it seems to compile correctly without any errors.

@vbraun
Copy link

vbraun commented Nov 17, 2023

+1

But also, how about removing the upper version limits? ngx-scanner breaks mostly because of that, and rarely / never because the Angular library format changed in incompatible ways (maybe once with the ViewEngine/Ivy transition).

@werthdavid
Copy link
Member

Thanks, much appreciated!

@werthdavid werthdavid merged commit 792ed52 into zxing-js:master Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants