Mem constructor for [base + index]

[TACIXAT]

Should the Mem constructor that takes base and index registers have scale set to 1 instead of 0?

zasm/include/zasm/x86/memory.hpp

Line 27 in 012062f

static constexpr Mem ptr(BitSize bitSize, const Gp& base, const Gp& index) noexcept

Succeeds:

a.mov(zasm::x86::al, zasm::x86::byte_ptr(zasm::x86::rsi, zasm::x86::rcx, 1, 0));

Fails impossible instruction:

a.mov(zasm::x86::al, zasm::x86::byte_ptr(zasm::x86::rsi, zasm::x86::rcx));

Likely cause:

    // ptr [base + index]
    // ex.: mov eax, ptr [ecx+edx]
    static constexpr Mem ptr(BitSize bitSize, const Gp& base, const Gp& index) noexcept
    {
        return Mem(bitSize, Seg{}, base, index, 0, 0);
    }

[ZehMatt]

I will have to look into that, I remember there was a special case about this.

[ZehMatt]

I've merged the change so its now 1 by default when index is supplied, thanks for the reporting the issue.