Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow #42

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Add CI workflow #42

merged 1 commit into from
Jan 24, 2022

Conversation

flobernd
Copy link
Member

No description provided.

@flobernd flobernd requested a review from athre0z January 24, 2022 11:24
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the time to finally do that! Not sure if we really need 32 bit builds for Linux -- there's probably less than 1000 users on the planet who still actively use that outside of Wine (which also started moving away from it by implementing WoW64), but I guess it doesn't hurt. If it ever starts making problems, I'd opt for just dropping it.

@flobernd
Copy link
Member Author

Would love to have CI for ICC and Borland as well to cover all our supported compilers, but as they are commercial, we are probably out of luck here.

@flobernd flobernd merged commit 9a305f6 into master Jan 24, 2022
@flobernd flobernd deleted the ci branch January 24, 2022 19:17
@athre0z
Copy link
Member

athre0z commented Jan 24, 2022

Borland C is largely dead and ICC is now Clang with a forked LLVM backend, so the current selection should be pretty good.

@flobernd
Copy link
Member Author

ICC is now Clang with a forked LLVM backend

Oh nice. Did not know about that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants