Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing (void) on functions without args #64

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

athre0z
Copy link
Member

@athre0z athre0z commented May 20, 2023

Multiple functions without arguments were missing the (void) that prevents them from being interpreted as not having a prototype. Newer Clang versions started printing warnings for that in pedantic mode.

Will send similar PR for Zydis once this is merged.

Multiple functions without arguments were missing the `(void)` that
prevents them from being interpreted as not having a prototype. Newer
Clang versions started printing warnings for that in pedantic mode.
@athre0z athre0z added C-bug Category: This is a bug A-build Area: Build system labels May 20, 2023
@athre0z athre0z requested a review from flobernd May 20, 2023 19:14
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit 685c335 into master May 21, 2023
@athre0z athre0z deleted the add-missing-void branch May 21, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants