Adding get_version function #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathanhdinh
force-pushed
the
add_get_version
branch
2 times, most recently
from
5b957ba to
71063cc
Compare
|
Nice, thanks! Would you mind adding a short documentation block before we merge this? |
tathanhdinh
force-pushed
the
add_get_version
branch
from
71063cc to
d0cce2b
Compare
|
Sure, I added it. |
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
The function
ZydisGetVersionreturns a combined value of(major, minor, patch, build). Since this feature of bindgen is not supported yet, we can not use existing macros, e.g. ZYDIS_VERSION_MAJOR to extract parts of the combined version. The PR allows: