Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload setting - finalization of #2627 #2845

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

JoeKar
Copy link
Collaborator

@JoeKar JoeKar commented Jun 16, 2023

Thanks to @wilbertom for the initial PR. I've created a new one and extended it with the requested default value including the documentation, since extending PRs by different people is a bit tricky.

Closes #2627

@wilbertom
Copy link
Contributor

@JoeKar thank you for taking the time to tackle this.

@zyedidia
Copy link
Owner

Thanks! Can we limit the changes here to just things relevant to the new option? Looks like there are some formatting changes to other documentation. If you think we should reformat some of the documentation we should address that with a separate PR.

Can be set to:

* auto - Automatically reload files that changed
* disabled - Do not reload files
* prompt - Prompt the user about reloading the file.
@JoeKar JoeKar force-pushed the feature/reload-setting branch from 35bffed to 38a433d Compare October 16, 2023 19:17
@JoeKar JoeKar force-pushed the feature/reload-setting branch from 38a433d to 531c1d7 Compare October 16, 2023 19:22
@JoeKar
Copy link
Collaborator Author

JoeKar commented Oct 16, 2023

Can we limit the changes here to just things relevant to the new option?

Done.

If you think we should reformat some of the documentation we should address that with a separate PR.

Yes, because the initial intention of these option was to somehow keep an alphabetical order. The options.md needs some reformatting.

@zyedidia zyedidia merged commit f7244d0 into zyedidia:master Oct 21, 2023
3 checks passed
@JoeKar JoeKar deleted the feature/reload-setting branch December 11, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants