Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split pane divider hovering over neighboring split pane #3070

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dmaluka
Copy link
Collaborator

@dmaluka dmaluka commented Dec 3, 2023

Fix the following funny issue: if we open 3 vertical split panes (i.e. with 2 vertical dividers between them) and drag the rightmost divider to the left (for resizing the middle and the rightmost split panes), it does not stop at the leftmost divider but jumps over it and then hovers over the leftmost split pane. And likewise with horizontal split panes.

Fix the following funny issue: if we open 3 vertical split panes (i.e.
with 2 vertical dividers between them) and drag the rightmost divider
to the left (for resizing the middle and the rightmost split panes), it
does not stop at the leftmost divider but jumps over it and then hovers
over the leftmost split pane. And likewise with horizontal split panes.
@dustdfg
Copy link
Contributor

dustdfg commented Dec 3, 2023

I am not sure if it is critical but this commit makes impossible to fully hide the leftmost split. It will have at least size of one character

screen-1701600076

@dmaluka
Copy link
Collaborator Author

dmaluka commented Dec 3, 2023

Yeah, right. Maybe it is not critical per se, but it would be good to understand what exactly is going on. At the moment I don't understand why size <= 0 prevents fully hiding the leftmost split but does not prevent fully hiding other splits. (Or in other words, why is size < 0 check not enough for preventing coalescing split panes, so that I had to use <= instead of <.)

Also, this issue might be just a tip of the deeper issue #3071.

@dustdfg
Copy link
Contributor

dustdfg commented Dec 3, 2023

I have a small guess related to one of my issues #3046 about wrong resize logic. Since resize logic can work wrong anything that relies on correct work can accidentally brake up

@JoeKar JoeKar merged commit 628d9bb into zyedidia:master Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants