Set bits in mode used when creating files #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set write permission bits of group and other users in mode used when opening files.
niten94
changed the title
|
Looks feasible. |
|
I do not think there is something else that has to be changed but the things I thought about changing has been changed in this pull request. If you thought I will make another pull request because I said I have not created one before, what I meant is that it is the first time I have created one. |
|
I'm sorry, I fully misunderstood it and confused myself. |
JoeKar
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bits set in the mode of files that are created are usually bits not set in the umask except execution bits, so files are usually opened with 0666 mode in other programs. The write permission bit of group and other users in the mode is usually cleared because they are set in the umask.
The bits are not set even if they are cleared in the umask when using micro, so the argument is changed in this pull request. I have not tested if it would work when changing the argument. I have also not made a pull request before, so it would be nice if I am told if there is something I did that is strange.