Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change when to save appLanguage #6

Merged

Conversation

hatemhosny
Copy link

@hatemhosny hatemhosny commented Sep 15, 2024

Set dir based on appLanguage

do not save appLanguage if is embed or when temporarily set in query params.

@zyf722 zyf722 merged commit 6054c4e into zyf722:i18next-integration-draft Sep 19, 2024
5 checks passed
hatemhosny pushed a commit that referenced this pull request Nov 26, 2024
fix typo + remove unused baseUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants