Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eml support #294

Closed
peterchanws opened this issue May 18, 2023 · 5 comments
Closed

eml support #294

peterchanws opened this issue May 18, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@peterchanws
Copy link

peterchanws commented May 18, 2023 •
edited
Loading

I had issue ingest eml files. #290
pseudotensor kindly have written code for that https://github.com/h2oai/h2ogpt#readme
https://github.com/h2oai/h2ogpt/blob/main/gpt_langchain.py#L364-L375
. I don't know how to integrate the code into privateGPT. Could someone merge the code to privateGPT?
Thanks
@peterchanws peterchanws added the enhancement New feature or request label May 18, 2023
@peterchanws peterchanws mentioned this issue May 18, 2023
Closed
@mdeweerd
Copy link
Contributor

mdeweerd commented May 18, 2023 •
edited
Loading

Check if https://github.com/mdeweerd/privateGPT/pull/new/elm_extended works for you and comment on PR #295 #299

@PulpCattel
Copy link

@mdeweerd You meant #299?

@mdeweerd
Copy link
Contributor

Yes, sorry for the typo.

@peterchanws
Copy link
Author

Sorry, I am not a coder. Could someone help to review? Thanks.

@peterchanws
Copy link
Author

I used ChatGPT to review the code and I got "Overall, the code seems to implement a fallback mechanism to handle cases where the default loading method for UnstructuredEmailLoader fails to find HTML content in an email."

imartinez added a commit that referenced this issue May 19, 2023
@imartinez
Merge pull request #299 from mdeweerd/elm_extended
22945bc 
Add fallback for plain elm #294 #290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterchanws @mdeweerd @PulpCattel