set worker's home directory #1618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
reviewed
Mar 26, 2024
| @@ -34,7 +34,7 @@ ENV PORT=8080 | |||
| EXPOSE 8080 | |||
|
|
|||
| # Prepare a non-root user | |||
| RUN adduser --system worker | |||
| RUN adduser --system --home /home/worker worker | |||
There was a problem hiding this comment.
👍 This is indeed important
Duplicated in my (larger) PR #1792
|
Closed. Merged #1792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some package depends on home directory to store cache data. If don't set, the home directory will point to /nonexistent, then those packages may show permission deny warning. It also prevents vs-code to attach to the container.