Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][offload] Break the fillbuffer loop when met EOF #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zymap
Copy link
Owner

@zymap zymap commented May 16, 2024


Motivation

When hit an EOF, the write bytes will return -1 then it would make the bytesToCoppy bigger than the buffer to fill. Then we will hit the java.lang.IndexOutOfBoundsException.
Break the look when hit the EOF, fill the buffer next time.

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

zymap added 2 commits May 16, 2024 10:48
---

### Motivation

When hit an EOF, the write bytes will return -1 then it would
make the bytesToCoppy bigger than the buffer to fill. Then we
will hit the java.lang.IndexOutOfBoundsException.
Break the look when hit the EOF, fill the buffer next time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant