Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load / save bug with drones #152

Closed
zymex22 opened this issue Aug 20, 2020 · 6 comments · Fixed by #170
Closed

load / save bug with drones #152

zymex22 opened this issue Aug 20, 2020 · 6 comments · Fixed by #170

Comments

@zymex22
Copy link
Owner

zymex22 commented Aug 20, 2020

Describe the bug
When trying to load or save with active drones out it will throug a error for "each" ? drones thats out.
this might be caused by a mod imcompat not sure i attached modlist

To Reproduce
Reproducibility: should be always with showed modlist?
Steps to reproduce the behavior:

  1. start a map, build some drone stations
  2. get drones out and working
  3. pause game and save. it will throw a error for each drone
  4. reload and it thorw another error

Expected behavior
No spam?

Actual Behavior
Much spam

Screenshots

When saved:

image
https://gist.github.com/79b3fd442a4e11169be0b609b19a769f

When loaded

image
https://gist.github.com/035d944741d413df24b662fb1d88d09f

image

image

Rimworld (please complete the following information):

  • RimWorld Version: 1.1 / 1.2
  • PRF Version: all
  • Link to gist bug report:
  • Type:
  • Severity:
  • Regression:

Modlist (please complete the following information):

  • Does this problem exist if only prf is installed:
  • Your modlist (if needed):
  • Do you know what mod conflicts?:

Additional context

@Sn1p3rr3c0n
Copy link
Collaborator

@zymex22 Work Tab is the Mod triggering this issue

@zymex22
Copy link
Owner Author

zymex22 commented Aug 20, 2020

make sense =) is it a prf problem or a work tab problem?

@Sn1p3rr3c0n
Copy link
Collaborator

i think its a Work Tab Issue.
see: fluffy-mods/WorkTab#134

@zymex22
Copy link
Owner Author

zymex22 commented Sep 11, 2020

so can we patch/fix it for us or something we should leave..
not sure if it causing any problems but its quiet annoying see when looking for other problems :P

if we should not or can not fix it we can close this i guess =)

@Sn1p3rr3c0n
Copy link
Collaborator

the issue seems to be that Work Tab Saves Drone Pawn by reference that do no longer exist.

in my test scenario i use one Drone station with 30 drones active.
Work Tab saves 69 Drone Pawns. consequently 39 unique warnings and 39 null ref errors are logged.

I will check if we are doing something wrong with the despawning but otherwise i think its a Work Tab bug

@Sn1p3rr3c0n
Copy link
Collaborator

Work Tab dose not save Pawns if they have the Destroyed flag set.
Therefor by simply setting this bool to true the issue can be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants