-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5touch: add V5-like touchscreen keypad to the UI #501
base: oram
Are you sure you want to change the base?
Conversation
Hi @wanthalf ! Excuse the radio silence. I'm quite busy on summer and had little time to read your code and test the changes. I will do ASAP. Regards, |
No problem. I see the tons of problems that must be finished and fixed ASAP! :) |
A question: once I noticed a state (that I cannot reproduce nor find in the code) where the (on-screen) wsleds were all turned off except the one indicating the active screen, which was pulsing in green. If there is such a state, I would suggest to change the "wscolor_off" from black to grey, so that the labels remain partially visible on the black background even when "turned off". The physical buttons also have their labels to some degree visible when the LEDs are turned off. |
That sounds like power save mode. In power save, the screen is switched off. I guess you may be testing via VNC, not to observe the lack of screen output? |
I see I also overlooked a few more geometry settings in The only screens really using the full display dimensions are probably the splash and the touchscreen calibration (and |
No feedback yet, so I tried to make the integration a bit cleaner myself by moving it into |
@@ -938,6 +938,14 @@ def get_state(self): | |||
b64_data = base64.b64encode(binary_riff_data) | |||
state['zynseq_riff_b64'] = b64_data.decode('utf-8') | |||
|
|||
# TouchKeypad config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any state/snapshot structure changes must be documented in zynthian_state_schema.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hint!
Touchscreen V5 keypad implementation as discussed in https://discourse.zynthian.org/t/diy-upgrading-to-v5-or-the-question-of-new-buttons/9707
(NOT everything was tested in depth yet.)
Requirements and options:
python3-cairosvg
to support SVG icons (should fall back to PNG if not available)ZYNTHIAN_TOUCH_KEYPAD
set toV5
to activate this extension (without this setting, the UI should behave exactly as before)ZYNTHIAN_TOUCH_KEYPAD_SIDE_LEFT
to activate the left side layout of the keypad (TRUE by default)zynthian_wsleds_v5touch.py
)