fix(livereload): wrong usage of reject, meant resolve. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebview fix(wkwebview): Images not loading in Ionic WKWebView
When running in an emulator or in a device with the flag --livereload images were not showing.
fix(livereload): Images not loading
Update to latest version merge
Reject caused an error and did not return the URL. Fixed this resolving and returning the image URL back to the promise.
|
Hi @ihadeed , sorry but my livereload fix had an error that I just found out. Here is the pull with the fix. Sorry for the problems this could've caused. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject caused an error and did not return the URL. Fixed this by resolving and returning the image URL back to the promise.