Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(livereload): wrong usage of reject, meant resolve. #167

Merged
merged 9 commits into from
Jul 4, 2018
Merged

fix(livereload): wrong usage of reject, meant resolve. #167

merged 9 commits into from
Jul 4, 2018

Commits on Jun 17, 2018

  1. fix(wkwebview): Images not loading in Ionic WKWebView

    @eduardoRoth
    eduardoRoth authored Jun 17, 2018
    Configuration menu
    Copy the full SHA
    79f8f3d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from eduardoRoth/eduardoRoth-patch-ios-ionicwkw… 

    …ebview

fix(wkwebview): Images not loading in Ionic WKWebView
    @eduardoRoth
    eduardoRoth authored Jun 17, 2018
    Configuration menu
    Copy the full SHA
    fc00969 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. fix(livereload): Images not loading 

    When running in an emulator or in a device with the flag --livereload images were not showing.
    @eduardoRoth
    eduardoRoth authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    367f674 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from eduardoRoth/eduardoRoth-fix-livereload 

    fix(livereload): Images not loading
    @eduardoRoth
    eduardoRoth authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    e12f4a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pr/3

    @eduardoRoth
    eduardoRoth authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    fd23fe5 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #4 from eduardoRoth/pr/3 

    Pr/3
    @eduardoRoth
    eduardoRoth authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    94b3b29 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2018

  1. lint(livereload): Updated for ihadeed comments

    @eduardoRoth
    eduardoRoth authored Jun 25, 2018
    Configuration menu
    Copy the full SHA
    5b5ccd1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. Merge pull request #5 from zyra/master 

    Update to latest version merge
    @eduardoRoth
    eduardoRoth authored Jul 2, 2018
    Configuration menu
    Copy the full SHA
    0e8c948 View commit details
    Browse the repository at this point in the history

  2. fix(livereload): Using reject instead of resolve 

    Reject caused an error and did not return the URL. Fixed this resolving and returning the image URL back to the promise.
    @eduardoRoth
    eduardoRoth authored Jul 2, 2018
    Configuration menu
    Copy the full SHA
    f4b5bd2 View commit details
    Browse the repository at this point in the history