Skip to content

fix(wkwebview): Images not loading in Ionic WKWebView #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2018
Merged

fix(wkwebview): Images not loading in Ionic WKWebView #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79f8f3d
fix(wkwebview): Images not loading in Ionic WKWebView
eduardoRoth Jun 17, 2018
fc00969
Merge pull request #1 from eduardoRoth/eduardoRoth-patch-ios-ionicwkw…
eduardoRoth Jun 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/providers/image-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Injectable } from '@angular/core';
import { DirectoryEntry, File, FileEntry, FileError } from '@ionic-native/file';
import { HttpClient } from '@angular/common/http';
import { normalizeUrl } from 'ionic-angular';
import { ImageLoaderConfig } from "./image-loader-config";
import { Platform } from 'ionic-angular';
import { Observable } from 'rxjs/Observable';
Expand Down Expand Up @@ -452,8 +453,8 @@ export class ImageLoader {
// therefore the file needs to be copied into that directory first!
if (this.isIonicWKWebView) {

// Ionic WKWebView can access all files, but we just need to replace file:/// with http://localhost:8080/
resolve(fileEntry.nativeURL.replace('file:///', 'http://localhost:8080/'));
// Use Ionic normalizeUrl to generate the right URL for Ionic WKWebView
resolve(normalizeUrl(fileEntry.nativeURL));

} else if (this.isWKWebView) {

Expand Down