Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add platform is cordova check for ionic serve / browser usage #78

Merged
merged 2 commits into from
Jul 15, 2017

Conversation

dmastag
Copy link
Contributor

@dmastag dmastag commented Jul 15, 2017

No description provided.

// we are running on a browser, or using livereload
// plugin will not function in this case
this.isInit = true;
this.init = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this isInit to init but the other instances still read isInit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, i just copied pasted from your comment here
#77 (comment)

@dmastag
Copy link
Contributor Author

dmastag commented Jul 15, 2017

Fixed

@ihadeed ihadeed merged commit a42d1d8 into zyra:master Jul 15, 2017
@ihadeed
Copy link
Member

ihadeed commented Jul 15, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants