Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#87] Feat: 짤 이미지 신고 확인 모달 UI 구현 #88

Merged
merged 10 commits into from
Mar 6, 2024
Merged

[#87] Feat: 짤 이미지 신고 확인 모달 UI 구현 #88

merged 10 commits into from
Mar 6, 2024

Commits on Mar 3, 2024

  1. Feat: 짤 이미지 신고 확인 모달 UI 구현 

    신고된 사진 제거 확인 모달 UI 코드 참고하여 구현
TODO: 짤 이미지 신고 api 연결 및 성공/실패 시 동작 구현
    @HY219
    HY219 committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    b1f5078 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Modify: ModalHeader 컴포넌트의 children Props를 옵셔널로 변경 

    전달한 children props가 없을 경우 Modal.Header를 좀 더 간결하게 작성
    @HY219
    HY219 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2306a90 View commit details
    Browse the repository at this point in the history

  2. Rename: 컨벤션과 역할에 맞게 이벤트 핸들러 함수 이름 수정 

    handleClickReport -> handleOpenReportConfirmModal
handleReport -> handleClickReport
줄 간격 띄움
    @HY219
    HY219 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    296deb3 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Refactor: hasCloseButton props에서 true 값 삭제 

    hasCloseButton props의 값은 동적으로 변경되지 않고 고정값 true를 가집니다.
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9e8ea4a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/zzalmyu/zzalmyu-frontend into 

    #87/feature/report-confirmation-modal-ui
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e5d4e0d View commit details
    Browse the repository at this point in the history

  3. Refactor: import 및 hook 호출 순서 변경 

    useState를 useOverlay 앞에 배치
코드의 가독성 향상 및 일관성 유지
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4603d10 View commit details
    Browse the repository at this point in the history

  4. Rename: 짤 이미지 상세모달에서 신고 버튼 클릭 시 호출되는 이벤트 핸들러 함수 이름 변경 

    handleOpenReportConfirmModal -> handleClickReportButton
어떤 동작을 하는 함수인지에 대한 설명이 아닌, 클릭했을 때 발생하는 동작을 설명해주는 이름이므로 변경
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    cbba680 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/zzalmyu/zzalmyu-frontend into 

    #87/feature/report-confirmation-modal-ui
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ffd1b47 View commit details
    Browse the repository at this point in the history

  6. Refactor: AlertTrigangle에 aria-label 추가 

    경고삼각형 아이콘
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6963cb8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of https://github.com/zzalmyu/zzalmyu-frontend into 

    #87/feature/report-confirmation-modal-ui
    @HY219
    HY219 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a588d1f View commit details
    Browse the repository at this point in the history