Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #133. Compatibility for custom IDbSet<> #134 #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for #133. Compatibility for custom IDbSet<> #134 #135

wants to merge 3 commits into from

Conversation

cocowalla
Copy link

Fix for #133. Adds compatibility for custom IDbSet<> implementations by looking for an ObjectQuery property after trying the existing checks

Fix for #133. Adds compatibility for custom `IDbSet<>` implementations
by looking for an `ObjectQuery` property after trying the existing
checks
@cocowalla
Copy link
Author

Note this does build OK locally and all tests pass.

The failed tests don't appear to be related to my commits, as the same tests were already failing in the master branch

Fix for #14. Build cache key from a hash of the SQL that will be
executed, along with any parameters and their values.

With the previous expression-based method, parameters and their values
were *not* being included in the cache key when `Include()` was used.
@cocowalla
Copy link
Author

So, because I forgot to create a feature branch in my fork before submitting the first PR, this now includes fixes for both #133 and #14. And the AppVeyor build is now succeeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant