Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "min_confirmation" feature for sharder request #303

Closed
cnlangzi opened this issue Aug 13, 2021 · 0 comments · Fixed by #305
Closed

Add "min_confirmation" feature for sharder request #303

cnlangzi opened this issue Aug 13, 2021 · 0 comments · Fixed by #305
Assignees
@cnlangzi
Labels
bug Something isn't working

Comments

@cnlangzi
Copy link
Contributor

cnlangzi commented Aug 13, 2021 •
edited
Loading

blobber/code/go/0chain.net/core/transaction/http.go

Line 269 in de66db8

if hashMaxCounter <= (numSharders / 2) {

It MUST same as gosdk's logic 0chain/gosdk#195

Please review all sharder requests, and apply the same logic

see more detail
@cnlangzi cnlangzi added the bug Something isn't working label Aug 13, 2021
@cnlangzi cnlangzi self-assigned this Aug 13, 2021
cnlangzi added a commit that referenced this issue Aug 14, 2021
@cnlangzi
fix(transactin):#303 added min_confirmation in 0chain_blobber.yml; re…
cfe8ca4 
…placed native http.Client with resty for performance
cnlangzi added a commit that referenced this issue Aug 14, 2021
@cnlangzi
fix(transaction):#303 removed SCRestAPIHandler from MakeSCRestAPICall
80c270d
@cnlangzi cnlangzi linked a pull request Aug 14, 2021 that will close this issue
Fix/min confimation #305
Merged
@cnlangzi cnlangzi mentioned this issue Aug 14, 2021
Merged
cnlangzi added a commit that referenced this issue Aug 16, 2021
@cnlangzi
fix(transaction):#303 moved default http values to resty
3dda34d
cnlangzi added a commit that referenced this issue Aug 16, 2021
@cnlangzi
fix(conf):#303 tidy gomod
4e68953
cnlangzi added a commit that referenced this issue Aug 16, 2021
@cnlangzi
fix(tansaction):#303 updated random logic
cf894e7
cnlangzi added a commit that referenced this issue Aug 16, 2021
@cnlangzi
fix(tansaction):#303 fixed golangci-lint
beeabfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnlangzi cnlangzi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/min confimation 0chain/blobber
1 participant
@cnlangzi