Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_confirmation doesn't work. #195

Closed
cnlangzi opened this issue Aug 7, 2021 · 0 comments · Fixed by #199
Closed

min_confirmation doesn't work. #195

cnlangzi opened this issue Aug 7, 2021 · 0 comments · Fixed by #199
Assignees
Labels
bug Something isn't working

Comments

@cnlangzi
Copy link
Contributor

cnlangzi commented Aug 7, 2021

min_confirmation is configured on ~/.zcn/config.yml, but it doesn't work.

if numSharders == 0 || float64(numSuccess*1.0/numSharders) > 0.5 {

	if numSharders == 0 || float64(numSuccess*1.0/numSharders) > 0.5 {
		if retTxn != nil {
			return retTxn, nil
		}
		return nil, errors.Wrap(customError, ErrNoTxnDetail)
	}
@cnlangzi cnlangzi added the bug Something isn't working label Aug 7, 2021
@cnlangzi cnlangzi self-assigned this Aug 7, 2021
cnlangzi added a commit that referenced this issue Aug 10, 2021
…error message in Test_Sharder_Verify_Txn_Failed
cnlangzi added a commit that referenced this issue Aug 10, 2021
…error message in Test_Sharder_Verify_Txn_Failed
cnlangzi added a commit that referenced this issue Aug 10, 2021
cnlangzi added a commit that referenced this issue Aug 12, 2021
cnlangzi added a commit that referenced this issue Aug 12, 2021
cnlangzi added a commit that referenced this issue Aug 14, 2021
cnlangzi added a commit that referenced this issue Aug 14, 2021
cnlangzi added a commit that referenced this issue Aug 16, 2021
cnlangzi added a commit that referenced this issue Aug 16, 2021
fix(transcation):#195 fixed min_confirmation bug on verify transaction
kushthedude added a commit that referenced this issue Aug 30, 2021
)

* fix(transcation):#195 fixed min_confirmation bug on veriry transaction

* fix(transcation):#195 removed fmt.Println

* fix(transcation):#195 test result based on ErrNoTxnDetail instead of error message in Test_Sharder_Verify_Txn_Failed

* fix(transcation):#195 test result based on ErrNoTxnDetail instead of error message in Test_Sharder_Verify_Txn_Failed

* fix(transcation):#195 fixed Test_Sharder_Verify_Txn_Failed

* fix(transcation):#195 fixed Test_Sharder_Verify_Txn_Failed

* fix(transcation):#195 removed go mod replace on go.mod

* fix(transcation):#195 remove global variables

* fix(transcation):#195 updated comment

* fix(transcation):#195 refactor old methods with conf.Config

* 🔨 revoke access for non encrypted files

* fix(transcation):#195 revert it with global variables, and removed LoadDefault in init

* fix(transcation):#195 added Network

* Delete build.go (#208)

* fix(conf):#195 moved magic number to predefined variables; added resty package

* fix(conf):#195 refactored mock code

* fix(conf):#195 fixed memory leak issue

* fix(conf):#195 close reponse.Body for avoid to memory leak

* fix(transaction):#195 update http reqeust with resty

* fix(error):0chain/errors#195 migrate errors

* fix(transaction):#195 fixed random issue

* fix(transaction):#195 fixed unit test

* fix(error):0chain/errors#195 migrate errors

* 🔨 fix unit tests

* fix(sdk):refactor sdk.InitStorageSDK with conf/Config

Co-authored-by: Lz <imlangzi@qq.com>
Co-authored-by: Artem Bogomaz <artembogomaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant