Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify/datetime #748

Merged
merged 70 commits into from
Jul 28, 2022
Merged

Modify/datetime #748

merged 70 commits into from
Jul 28, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jul 6, 2022 •
edited
Loading

Changes

  • Optimize allocation changes functions
  • Fix issue directory renaming
  • Directory can only be created with commit request

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

lpoli and others added 28 commits June 6, 2022 15:01
@lpoli
Remove whopays attribute
ddf5e78
@lpoli
Remove dot logger
f5116c5
@lpoli
Fix hashes of test
4ef07a6
@lpoli
Remove redundant payer id field
2a9dd4d
@lpoli
Remove authticket association with readmarker
99c2c1d
@peterlimg
Merge branch 'staging' into fix/update-attributes
4c8fe68
@peterlimg
Fix conflicts
aa4fb4d
@lpoli
Remove proto file
c388172
@lpoli
Merge branch 'fix/update-attributes' of https://github.com/0chain/blo…
f28da9a 
…bber into fix/update-attributes
@peterlimg
Update go modules
352a3fd
@peterlimg
Resolve go mod conflicts
82d116a
@lpoli
Merge branch 'staging' into fix/update-attributes
36e80ea
@lpoli
Generate/Update grpc code
aa07fce
@lpoli
Go mod tidy
16afa4f
@lpoli
Remove payer in test insertion
5457487
@lpoli
Make reader pay for read instead of owner
4d90534
@cnlangzi
Merge branch 'staging' into fix/update-attributes
4b3f827
@lpoli
Merge branch 'staging' into fix/update-attributes
461ec71
@lpoli
Go mod tidy
943a1d1
@lpoli
error ret
a3c6fff
@lpoli
Add separate handler for directory creation
c4c53f4
@lpoli
Separate directory creation handling
f5fa697
@lpoli
Replace time.Time with common.Timestamp in refs
9490b2b 
Remove deleted_at column
Update tests
Optimize *change.go files
@lpoli
Optimize upload file changer
380652c
@lpoli
Remove unrequired files
8826b0d
@lpoli
Remove dot import and fmt prints
28e3d8d
@lpoli
Merge branch 'staging' into modify/datetime
c60433c
@lpoli
Fix imports
b93be74
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #748 (29b68f4) into staging (ce26910) will increase coverage by 0.78%.
The diff coverage is 33.65%.

@@             Coverage Diff             @@
##           staging     #748      +/-   ##
===========================================
+ Coverage    23.59%   24.37%   +0.78%     
===========================================
  Files           77       77              
  Lines         7980     7818     -162     
===========================================
+ Hits          1883     1906      +23     
+ Misses        5828     5646     -182     
+ Partials       269      266       -3
Flag Coverage Δ
Unit-Tests 24.37% <33.65%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/allocation/allocationchange.go 0.00% <0.00%> (ø)
...ain.net/blobbercore/allocation/deletefilechange.go 0.00% <0.00%> (ø)
.../0chain.net/blobbercore/allocation/newdirchange.go 0.00% <0.00%> (ø)
.../go/0chain.net/blobbercore/handler/grpc_handler.go 7.74% <ø> (+0.72%) ⬆️
code/go/0chain.net/blobbercore/handler/handler.go 57.35% <ø> (+0.27%) ⬆️
...o/0chain.net/blobbercore/handler/handler_common.go 19.10% <ø> (+1.75%) ⬆️
...et/blobbercore/handler/object_operation_handler.go 32.72% <0.00%> (+2.76%) ⬆️
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)
.../0chain.net/blobbercore/handler/storage_handler.go 25.21% <0.00%> (+1.44%) ⬆️
code/go/0chain.net/blobbercore/reference/object.go 0.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@lpoli lpoli mentioned this pull request Jul 14, 2022
Merged
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests modify/datetime
gosdk modify/datetime
zboxcli modify/datetime
zwalletcli staging
0chain staging
blobber modify/datetime
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli lpoli mentioned this pull request Jul 15, 2022
Merged
peterlimg
peterlimg requested changes Jul 22, 2022
View reviewed changes
code/go/0chain.net/blobbercore/reference/ref.go
func (r *Ref) CalculateDirHash(ctx context.Context, saveToDB bool) (h string, err error) {
defer func() {
if err == nil && saveToDB {
err = r.SaveDirRef(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defer actions would call the r.SaveDirRef when there's no child.

peterlimg
peterlimg approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber modify/datetime
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli merged commit 2e2fe75 into staging Jul 28, 2022
@lpoli lpoli deleted the modify/datetime branch July 28, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpoli @codecov-commenter @service-0chain @peterlimg @cnlangzi