Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify/datetime #274

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Modify/datetime #274

merged 10 commits into from
Jul 28, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jul 15, 2022

A brief description of the changes in this PR:

This PR Upgrades gosdk to latest commit of modify/datetime gosdk branch.
Description in blobber PR.. and gosdk PR

Associated PRs (Link as appropriate):

@lpoli lpoli requested review from dabasov and peterlimg July 15, 2022 13:10
peterlimg
peterlimg approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests modify/datetime
gosdk modify/datetime
zboxcli modify/datetime
zwalletcli staging
0chain staging
blobber modify/datetime
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests modify/datetime
gosdk modify/datetime
zboxcli modify/datetime
zwalletcli staging
0chain staging
blobber modify/datetime
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli modify/datetime
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli lpoli merged commit 5aa363a into staging Jul 28, 2022
@lpoli lpoli deleted the modify/datetime branch July 28, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpoli @service-0chain @peterlimg