Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Swagger #876

Merged
merged 19 commits into from
Mar 23, 2023
Merged

Setup Swagger #876

merged 19 commits into from
Mar 23, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Nov 14, 2022 •
edited by peterlimg
Loading

Changes

blobber REST endpoints documentation using swagger

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

peterlimg
peterlimg approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boddumanohar boddumanohar force-pushed the swagger branch 2 times, most recently from 86ee11e to 1795b2a Compare November 18, 2022 11:00
@boddumanohar boddumanohar marked this pull request as draft November 18, 2022 21:23
@boddumanohar boddumanohar marked this pull request as ready for review November 22, 2022 17:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #876 (3404a59) into staging (3e2024d) will decrease coverage by 0.05%.
The diff coverage is 17.64%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #876      +/-   ##
===========================================
- Coverage    26.18%   26.14%   -0.05%     
===========================================
  Files           76       76              
  Lines         7744     7756      +12     
===========================================
  Hits          2028     2028              
- Misses        5444     5456      +12     
  Partials       272      272
Flag Coverage Δ
Unit-Tests 26.14% <17.64%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../go/0chain.net/blobbercore/handler/handler_main.go 85.71% <ø> (ø)
code/go/0chain.net/blobbercore/handler/handler.go 61.17% <17.64%> (-1.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@boddumanohar boddumanohar mentioned this pull request Feb 5, 2023
Closed
@boddumanohar boddumanohar linked an issue Feb 5, 2023 that may be closed by this pull request
blobber REST endpoints documentation using swagger #873
Closed
@boddumanohar boddumanohar force-pushed the swagger branch 2 times, most recently from df4c20f to dc0c507 Compare February 16, 2023 20:18
peterlimg
peterlimg previously requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boddumanohar Please fix the lint error

@boddumanohar boddumanohar requested a review from peterlimg March 1, 2023 18:39
dabasov
dabasov approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit ef77ef9 into staging Mar 23, 2023
@dabasov dabasov deleted the swagger branch March 23, 2023 20:45
peterlimg added a commit that referenced this pull request Mar 24, 2023
@peterlimg
Merge branch 'staging' into chain-fee
cd183aa 
* staging:
  Fix: typos (#950)
  Setup Swagger  (#876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blobber REST endpoints documentation using swagger
5 participants
@boddumanohar @codecov-commenter @dabasov @peterlimg @shahnawaz-creator