added nat to docker builds #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahnawaz-creator
requested review from
peterlimg,
dabasov,
guruhubb and
cnlangzi
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## swagger #998 +/- ##
========================================
Coverage 27.74% 27.74%
========================================
Files 77 77
Lines 8089 8089
========================================
Hits 2244 2244
Misses 5554 5554
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@shahnawaz-creator blobber building process seems got stuck |
dabasov
pushed a commit
that referenced
this pull request
Mar 23, 2023
* init swagger * swagger doc for rename handler * add new endpoint * Check swagger generation * swagger generation * Add swagger endpoints * update Dockerfile for blobber_base * remove /swagger.yaml registration * create a new mux instead of the default mux * clean up * setup handler * added nat to docker builds (#998) added nat to docker builds * added host network (#1005) --------- Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):