Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error returned from CreateMSWallet if threshold < 1 #199

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix error returned from CreateMSWallet if threshold < 1 #199

merged 1 commit into from
Feb 25, 2022

Conversation

shaktals
Copy link
Contributor

Fix that go along updates on zwalletcli PR #92, which validates that createmswallet threshold should be bigger than 0.

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests validate-createmswallet-threshold
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli createmswallet-threshold-fix
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Kishan-Dhakan
Kishan-Dhakan approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit e2ec281 into master Feb 25, 2022
@cnlangzi cnlangzi mentioned this pull request Feb 25, 2022
Merged
1 task
@cnlangzi cnlangzi deleted the validate-createmswallet-threshold branch February 25, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@stewartie4 stewartie4 Awaiting requested review from stewartie4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaktals @service-0chain @Kishan-Dhakan @cnlangzi