Validate that createmswallet threshold is bigger than 0

[shaktals]

Tasks to complete before merging PR:

• [x ] Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• [x ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Resolves #49

[shaktals]

I'll work on the system tests to fix them.

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	validate-createmswallet-threshold
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	createmswallet-threshold-fix
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[Kishan-Dhakan]

LGTM

[Kishan-Dhakan]

Thanks @shaktals! Client side validation on this is great as it reduces overhead. The panic itself is thrown in goSDK, since our SDK is open for others to use I'll raise a PR there to fix the underlying issue.

Edit: Fixed via: 0chain/gosdk#405

[cnlangzi]

@Kishan-Dhakan @shaktals this PR seems break 0Chain System Test ? see https://github.com/0chain/zwalletcli/runs/5261772741?check_suite_focus=true. it should not be merged to staging. it blocks other PRs again.

[cnlangzi]

I know why it fails. @shaktals you forget to merge 0chain/system_test#199 first.

[shaktals]

@cnlangzi I got this instruction to merge the feature branch first. But maybe I missed the point of doing the merges one right after another.

[cnlangzi]

0chain/system_test#199

@shaktals Actually, you forget to merge 0chain/system_test#199 :)

[shaktals]

@cnlangzi I did not forget anything.
When @Kishan-Dhakan approved it, I was taking care of other tasks.
You just got to it before I did.

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests
gosdk	NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns