Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define different client names for the same group #251

Closed
0xERR0R opened this issue Aug 23, 2021 · 0 comments · Fixed by #337
Closed

Define different client names for the same group #251

0xERR0R opened this issue Aug 23, 2021 · 0 comments · Fixed by #337
Labels
🔨 enhancement New feature or request
Milestone
v0.17

Comments

@0xERR0R
Copy link
Owner

0xERR0R commented Aug 23, 2021

It should be possible to define more than one client name (IP, wildcard etc) for the group. Example:

  clientGroupsBlock:
    # multiple client names are separated by ','
    laptop,desktop*:
      - ads
    192.168.178.1/24:
      - special
@0xERR0R 0xERR0R mentioned this issue Aug 23, 2021
Closed
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Aug 23, 2021
@0xERR0R 0xERR0R added this to the 0.16 milestone Sep 3, 2021
@0xERR0R 0xERR0R modified the milestones: 0.16, 0.17 Sep 18, 2021
kwitsch added a commit to kwitsch/blocky-dev that referenced this issue Nov 12, 2021
@kwitsch
Merge remote-tracking branch 'origin/development' into 0xERR0R#251
f5ee7f3 
# Conflicts:
#	go.mod
#	go.sum
kwitsch added a commit to kwitsch/blocky-dev that referenced this issue Nov 12, 2021
@kwitsch
Merge remote-tracking branch 'origin/development' into 0xERR0R#251
b279ac9
@0xERR0R 0xERR0R linked a pull request Nov 14, 2021 that will close this issue
Define different client names for the same group (#251) #337
Merged
@0xERR0R 0xERR0R mentioned this issue Nov 14, 2021
Merged
0xERR0R pushed a commit that referenced this issue Nov 14, 2021
@kwitsch
Allow to define different client names for the same group (#251) (#337)
bd1886d 
* comama seperated client names

(cherry picked from commit cdb009d)

* blocking_resolver unittest

(cherry picked from commit cb059de)

* linter errors reduced

* unit test for group merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 enhancement New feature or request
Projects
None yet
Milestone
v0.17
Development

Successfully merging a pull request may close this issue.

Define different client names for the same group (#251) kwitsch/blocky-dev
1 participant
@0xERR0R