Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define different client names for the same group (#251) #337

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 12, 2021

different client names for the same group

(cherry picked from commit cdb009d)
(cherry picked from commit cb059de)
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #337 (6afc9f6) into development (e882fa0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #337      +/-   ##
===============================================
+ Coverage        96.11%   96.13%   +0.01%     
===============================================
  Files               30       30              
  Lines             2216     2225       +9     
===============================================
+ Hits              2130     2139       +9     
  Misses              56       56              
  Partials            30       30              
Impacted Files Coverage Δ
resolver/blocking_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e882fa0...6afc9f6. Read the comment docs.

@kwitsch kwitsch changed the title Ticket #251 Define different client names for the same group (#251) Nov 13, 2021
@0xERR0R 0xERR0R linked an issue Nov 14, 2021 that may be closed by this pull request
@0xERR0R 0xERR0R added this to the 0.17 milestone Nov 14, 2021
@0xERR0R
Copy link
Owner

0xERR0R commented Nov 14, 2021

Thank you for your work! 🤝

@0xERR0R
Copy link
Owner

0xERR0R commented Nov 14, 2021

closes #251

@0xERR0R 0xERR0R merged commit bd1886d into 0xERR0R:development Nov 14, 2021
@kwitsch kwitsch deleted the ticket_#251 branch November 15, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define different client names for the same group
2 participants