Feature/3518 use generic eth client for l2 #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
requested review from
tclemos,
ARR552,
ToniRamirezM,
dpunish3r and
agnusmor
as code owners
tclemos
approved these changes
Apr 3, 2024
joanestebanr
added a commit
that referenced
this pull request
Apr 4, 2024
* #3518 compatibility with ethereum-API L2 node * migrate docker-compose to v2 because ubuntu:latest have deprecated it * fix case trusted URL is not set
joanestebanr
added a commit
that referenced
this pull request
Apr 4, 2024
joanestebanr
added
the
cherry-picked
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
* 0xPolygonHermez#3518 compatibility with ethereum-API L2 node * migrate docker-compose to v2 because ubuntu:latest have deprecated it * fix case trusted URL is not set
Stefan-Ethernal
added a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
* fix tx index calculation on receipt (0xPolygonHermez#3488) * fix debug trace to compute egp percentage based on tx execution values (0xPolygonHermez#3503) * fix debug trace to compute egp percentage based on tx execution values * fix trace egp percentage for injected tx * sort logs by tx hash and then by log index (0xPolygonHermez#3476) * * Fix ResetL1InfoRoot + typos * mocks * linter * refactor * more robust * Fix comments * Add extra check reorg after calling get information * Fix non e2e test * Feature/3518 use generic eth client for l2 (0xPolygonHermez#3519) * 0xPolygonHermez#3518 compatibility with ethereum-API L2 node * migrate docker-compose to v2 because ubuntu:latest have deprecated it * fix case trusted URL is not set * fix deltaTimeStamp and TimestampLimit for eth_call (0xPolygonHermez#3529) * Stop syncing l1inforoot when invalid l1inforoot is detected (0xPolygonHermez#3542) * stop syncing l1inforoot when invalid l1inforoot is detected * fix linter * Feature/0xPolygonHermez#3544 sync block protection (0xPolygonHermez#3545) * SyncBlockProtection parameter * linter * config * Fix unit test * add column checked on state.block (0xPolygonHermez#3543) * add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000 * safe mode by default (0xPolygonHermez#3547) * safe mode by default * doc * update docs * Update the diff --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com> Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Rachit Sonthalia <rachitsonthalia02@gmail.com>
GIgako19929
reviewed
Oct 24, 2024
| @@ -37,6 +37,7 @@ import ( | |||
| "github.com/0xPolygonHermez/zkevm-node/state/runtime/executor" | |||
| "github.com/0xPolygonHermez/zkevm-node/synchronizer" | |||
| "github.com/0xPolygonHermez/zkevm-node/synchronizer/common/syncinterfaces" | |||
| "github.com/ethereum/go-ethereum/ethclient" | |||
| @@ -5,7 +5,6 @@ import ( | |||
| "math/big" | |||
| "testing" | |||
|
|
|||
| rpctypes "github.com/0xPolygonHermez/zkevm-node/jsonrpc/types" | |||
| @@ -5,7 +5,6 @@ import ( | |||
| "math/big" | |||
| "testing" | |||
|
|
|||
| rpctypes "github.com/0xPolygonHermez/zkevm-node/jsonrpc/types" | |||
| @@ -19,7 +18,7 @@ import ( | |||
| type CheckL2BlocksTestData struct { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3518
What does this PR do?
A trusted synchronizer can use a ethereum compatibility API to check L2block hashes
Reviewers
Main reviewers: