-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop syncing l1inforoot when invalid l1inforoot is detected #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
Content has been cherry-picked into a higher version branch
zkevm-seq-agg
labels
Apr 8, 2024
ToniRamirezM
approved these changes
Apr 8, 2024
agnusmor
added a commit
that referenced
this pull request
Apr 10, 2024
* stop syncing l1inforoot when invalid l1inforoot is detected * fix linter
agnusmor
added a commit
that referenced
this pull request
Apr 10, 2024
…root is detected (#3552) * Add sanity-check on checkL1InfoTreeUpdate to check state L1 blockhash matches ethereum blockhash (L1 reorg check) (#3480) * Add sanity check on checkL1InfoTreeUpdate to check state L1 blockhash matches ethereum blockhash (L1 reorg check) * fix L1 block is 0 (empty l1infotree) * Update Prover image to v5.0.9 * Stop syncing l1inforoot when invalid l1inforoot is detected (#3542) * stop syncing l1inforoot when invalid l1inforoot is detected * fix linter
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
…nHermez#3542) * stop syncing l1inforoot when invalid l1inforoot is detected * fix linter
Stefan-Ethernal
added a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
* fix tx index calculation on receipt (0xPolygonHermez#3488) * fix debug trace to compute egp percentage based on tx execution values (0xPolygonHermez#3503) * fix debug trace to compute egp percentage based on tx execution values * fix trace egp percentage for injected tx * sort logs by tx hash and then by log index (0xPolygonHermez#3476) * * Fix ResetL1InfoRoot + typos * mocks * linter * refactor * more robust * Fix comments * Add extra check reorg after calling get information * Fix non e2e test * Feature/3518 use generic eth client for l2 (0xPolygonHermez#3519) * 0xPolygonHermez#3518 compatibility with ethereum-API L2 node * migrate docker-compose to v2 because ubuntu:latest have deprecated it * fix case trusted URL is not set * fix deltaTimeStamp and TimestampLimit for eth_call (0xPolygonHermez#3529) * Stop syncing l1inforoot when invalid l1inforoot is detected (0xPolygonHermez#3542) * stop syncing l1inforoot when invalid l1inforoot is detected * fix linter * Feature/0xPolygonHermez#3544 sync block protection (0xPolygonHermez#3545) * SyncBlockProtection parameter * linter * config * Fix unit test * add column checked on state.block (0xPolygonHermez#3543) * add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000 * safe mode by default (0xPolygonHermez#3547) * safe mode by default * doc * update docs * Update the diff --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com> Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Rachit Sonthalia <rachitsonthalia02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop syncing l1inforoot when invalid l1inforoot is detected (L1 reorg)
Reviewers
Main reviewers:
@ToniRamirezM
@joanestebanr
@ARR552