This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Fix use of L2coinbase configured in sequencesender.L2Coinbase parameter #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
agnusmor
requested review from
ToniRamirezM,
dpunish3r,
tclemos and
ARR552
as code owners
agnusmor
changed the title
agnusmor
added a commit
that referenced
this pull request
May 22, 2024
…er (#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc
agnusmor
added a commit
that referenced
this pull request
Jun 6, 2024
…er (#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Jun 26, 2024
…er (0xPolygonHermez#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Jun 26, 2024
…er (0xPolygonHermez#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc
Stefan-Ethernal
added a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Jul 2, 2024
* Update DS Format (0xPolygonHermez#3608) * protobuf datastream * proto batch end (0xPolygonHermez#3612) * fix genesis DS (0xPolygonHermez#3615) * Fix DSSendL2Block batch number (0xPolygonHermez#3617) * Fix DSSendL2Block batch number * latest proto (0xPolygonHermez#3620) * Fix DSSendBatchEnd (0xPolygonHermez#3621) * add TxFeeCap config (0xPolygonHermez#3611) * Add delay when getting storedFlushId from the executor/hashdb (0xPolygonHermez#3625) * Add sleep delay when getting storedFlushId from the executor/hashdb * update config doc * Fix use of L2coinbase configured in sequencesender.L2Coinbase parameter (0xPolygonHermez#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc * Feature/3640 synchronizer choose to sync from l2 (0xPolygonHermez#3641) * 0xPolygonHermez#3640. New Param Synchronizer.L2Synchronization.Enable to choose if sync from L2 * change synchronization config params 'Enable' to 'Enabled' (0xPolygonHermez#3656) * change 'Enable' to 'Enabled' on sync config and changed comments * Cherry-pick 0xPolygonHermez#3650: Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3654) * Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3650) * Do fatal when datastream channel is full (this will restart sequencer automatically) * update datastream library (more ds-debug logs) * fix decrease DataToStreamChannelCount * add optimistic gas computation while estimating gas (0xPolygonHermez#3653) * Use Eth block hash for l2 blocks in data stream (0xPolygonHermez#3661) * Use Eth block hash for l2 blocks in data stream * handle minTimestamp * empty imStateRoot (0xPolygonHermez#3663) * empty imStateRoot * fix comment * Cherry-pick 0xPolygonHermez#3659,0xPolygonHermez#3662: Remove sync with virtual state (synchronizer). Add L1 block confirmations (0xPolygonHermez#3666) * Remove sync with virtual state (synchronizer). Add L1 block confirmat… (0xPolygonHermez#3659) * Remove sync with virtual state (synchronizer). Add L1 block confirmations to consider sequence final * fix get monitored tx receipt * update doc * Skip wait L1 block confirmations after restart (0xPolygonHermez#3662) * skip wait L1 block confirmations after restart * skip checking last batch sequenced in SC after restart * set default value of SequenceL1BlockConfirmations to 32 * set default value of SequenceL1BlockConfirmations to 2 for debug/test * fix config_test * fix doc * remove db tx from RPC (0xPolygonHermez#3648) (0xPolygonHermez#3683) * remove synchronizer dependency from eth tx manager to confirm monitored tx (0xPolygonHermez#3658) (0xPolygonHermez#3677) * Cherry-pick 0xPolygonHermez#3669: Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3690) * Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3669) * Add WriteTimeout config parameter to StreamServer. Update DS library * update doc * update default value for StreamServer.WriteTimeout config parameter. Increase buffer for datastream channel * fix doc * fix config test * fix doc * change imstateroot handling in DS (0xPolygonHermez#3698) * change imstateroot handling in DS * Fix tests * Generate node config doc * Update the diff --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com>
akonring
added a commit
to EspressoSystems/cdk-validium-node
that referenced
this pull request
Jul 25, 2024
* Adding initial for deb packaging for amd64 * Fix typo in comment * Removing unnecessary directory creation, artifact from testing * Adding fix for mkdir in postinstall * Fix broken Unit declaration in service file * Integrate the `zkevm-node` v0.7.0 changes (0xPolygon#146) * Update DS Format (0xPolygonHermez#3608) * protobuf datastream * proto batch end (0xPolygonHermez#3612) * fix genesis DS (0xPolygonHermez#3615) * Fix DSSendL2Block batch number (0xPolygonHermez#3617) * Fix DSSendL2Block batch number * latest proto (0xPolygonHermez#3620) * Fix DSSendBatchEnd (0xPolygonHermez#3621) * add TxFeeCap config (0xPolygonHermez#3611) * Add delay when getting storedFlushId from the executor/hashdb (0xPolygonHermez#3625) * Add sleep delay when getting storedFlushId from the executor/hashdb * update config doc * Fix use of L2coinbase configured in sequencesender.L2Coinbase parameter (0xPolygonHermez#3642) * fix use l2coinbase configured in sequencesender.L2Coinbase parameter * update doc * Feature/3640 synchronizer choose to sync from l2 (0xPolygonHermez#3641) * 0xPolygonHermez#3640. New Param Synchronizer.L2Synchronization.Enable to choose if sync from L2 * change synchronization config params 'Enable' to 'Enabled' (0xPolygonHermez#3656) * change 'Enable' to 'Enabled' on sync config and changed comments * Cherry-pick 0xPolygonHermez#3650: Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3654) * Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3650) * Do fatal when datastream channel is full (this will restart sequencer automatically) * update datastream library (more ds-debug logs) * fix decrease DataToStreamChannelCount * add optimistic gas computation while estimating gas (0xPolygonHermez#3653) * Use Eth block hash for l2 blocks in data stream (0xPolygonHermez#3661) * Use Eth block hash for l2 blocks in data stream * handle minTimestamp * empty imStateRoot (0xPolygonHermez#3663) * empty imStateRoot * fix comment * Cherry-pick 0xPolygonHermez#3659,0xPolygonHermez#3662: Remove sync with virtual state (synchronizer). Add L1 block confirmations (0xPolygonHermez#3666) * Remove sync with virtual state (synchronizer). Add L1 block confirmat… (0xPolygonHermez#3659) * Remove sync with virtual state (synchronizer). Add L1 block confirmations to consider sequence final * fix get monitored tx receipt * update doc * Skip wait L1 block confirmations after restart (0xPolygonHermez#3662) * skip wait L1 block confirmations after restart * skip checking last batch sequenced in SC after restart * set default value of SequenceL1BlockConfirmations to 32 * set default value of SequenceL1BlockConfirmations to 2 for debug/test * fix config_test * fix doc * remove db tx from RPC (0xPolygonHermez#3648) (0xPolygonHermez#3683) * remove synchronizer dependency from eth tx manager to confirm monitored tx (0xPolygonHermez#3658) (0xPolygonHermez#3677) * Cherry-pick 0xPolygonHermez#3669: Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3690) * Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3669) * Add WriteTimeout config parameter to StreamServer. Update DS library * update doc * update default value for StreamServer.WriteTimeout config parameter. Increase buffer for datastream channel * fix doc * fix config test * fix doc * change imstateroot handling in DS (0xPolygonHermez#3698) * change imstateroot handling in DS * Fix tests * Generate node config doc * Update the diff --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com> * Added Polygon R&D Link (0xPolygon#147) --------- Co-authored-by: Daniel Jones <djones@polygon.technology> Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com> Co-authored-by: Daniel Jones <105369507+djpolygon@users.noreply.github.com> Co-authored-by: AMAN PANDEY <34401078+johnsoncarl@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2739, #3537
What does this PR do?
Fixes use of L2Coinbase address configured in SequenceSender.L2Coinbase parameter instead of use the sequencer address since these 2 addresses can be different. In case they were different we get a "trusted reorg" as commented in the issues #2739 #3537
Reviewers
Main reviewers:
@ToniRamirezM
@joanestebanr
@ARR552