Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove db tx from RPC #3648

Merged
merged 2 commits into from
May 29, 2024
Merged

remove db tx from RPC #3648

merged 2 commits into from
May 29, 2024

Conversation

tclemos
Copy link
Contributor

@tclemos tclemos commented May 22, 2024

Closes #3628.

What does this PR do?

Removes the use of DB tx from RPC

@tclemos tclemos added this to the v0.7.0 milestone May 22, 2024
@tclemos tclemos self-assigned this May 22, 2024
@cla-bot cla-bot bot added the cla-signed label May 22, 2024
@tclemos tclemos merged commit d2d0af6 into develop May 29, 2024
19 of 20 checks passed
@tclemos tclemos deleted the feature/rpc-db-tx-refactoring branch May 29, 2024 12:57
tclemos added a commit that referenced this pull request Jun 4, 2024
tclemos added a commit that referenced this pull request Jun 4, 2024
tclemos added a commit that referenced this pull request Jun 4, 2024
tclemos added a commit that referenced this pull request Jun 5, 2024
Stefan-Ethernal pushed a commit to 0xPolygon/cdk-validium-node that referenced this pull request Jun 26, 2024
Stefan-Ethernal pushed a commit to 0xPolygon/cdk-validium-node that referenced this pull request Jun 26, 2024
Stefan-Ethernal added a commit to 0xPolygon/cdk-validium-node that referenced this pull request Jul 2, 2024
* Update DS Format (0xPolygonHermez#3608)

* protobuf datastream

* proto batch end (0xPolygonHermez#3612)

* fix genesis DS (0xPolygonHermez#3615)

* Fix DSSendL2Block batch number (0xPolygonHermez#3617)

* Fix DSSendL2Block batch number

* latest proto (0xPolygonHermez#3620)

* Fix DSSendBatchEnd (0xPolygonHermez#3621)

* add TxFeeCap config (0xPolygonHermez#3611)

* Add delay when getting storedFlushId from the executor/hashdb (0xPolygonHermez#3625)

* Add sleep delay when getting storedFlushId from the executor/hashdb

* update config doc

* Fix use of L2coinbase configured in sequencesender.L2Coinbase parameter (0xPolygonHermez#3642)

* fix use l2coinbase configured in sequencesender.L2Coinbase parameter

* update doc

* Feature/3640 synchronizer choose to sync from l2 (0xPolygonHermez#3641)

* 0xPolygonHermez#3640. New Param Synchronizer.L2Synchronization.Enable to choose if sync from L2

* change synchronization config params 'Enable' to 'Enabled' (0xPolygonHermez#3656)

* change 'Enable' to 'Enabled' on sync config and changed comments

* Cherry-pick 0xPolygonHermez#3650: Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3654)

* Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3650)

* Do fatal when datastream channel is full (this will restart sequencer automatically)

* update datastream library (more ds-debug logs)

* fix decrease DataToStreamChannelCount

* add optimistic gas computation while estimating gas (0xPolygonHermez#3653)

* Use Eth block hash for l2 blocks in data stream (0xPolygonHermez#3661)

* Use Eth block hash for l2 blocks in data stream

* handle minTimestamp

* empty imStateRoot (0xPolygonHermez#3663)

* empty imStateRoot

* fix comment

* Cherry-pick 0xPolygonHermez#3659,0xPolygonHermez#3662: Remove sync with virtual state (synchronizer). Add L1 block confirmations (0xPolygonHermez#3666)

* Remove sync with virtual state (synchronizer). Add L1 block confirmat… (0xPolygonHermez#3659)

* Remove sync with virtual state (synchronizer). Add L1 block confirmations to consider sequence final

* fix get monitored tx receipt

* update doc

* Skip wait L1 block confirmations after restart (0xPolygonHermez#3662)

* skip wait L1 block confirmations after restart

* skip checking last batch sequenced in SC after restart

* set default value of SequenceL1BlockConfirmations to 32

* set default value of SequenceL1BlockConfirmations to 2 for debug/test

* fix config_test

* fix doc

* remove db tx from RPC (0xPolygonHermez#3648) (0xPolygonHermez#3683)

* remove synchronizer dependency from eth tx manager to confirm monitored tx (0xPolygonHermez#3658) (0xPolygonHermez#3677)

* Cherry-pick 0xPolygonHermez#3669: Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3690)

* Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3669)

* Add WriteTimeout config parameter to StreamServer. Update DS library

* update doc

* update default value for StreamServer.WriteTimeout config parameter. Increase buffer for datastream channel

* fix doc

* fix config test

* fix doc

* change imstateroot handling in DS (0xPolygonHermez#3698)

* change imstateroot handling in DS

* Fix tests

* Generate node config doc

* Update the diff

---------

Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com>
Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com>
Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com>
akonring added a commit to EspressoSystems/cdk-validium-node that referenced this pull request Jul 25, 2024
* Adding initial for deb packaging for amd64

* Fix typo in comment

* Removing unnecessary directory creation, artifact from testing

* Adding fix for mkdir in postinstall

* Fix broken Unit declaration in service file

* Integrate the `zkevm-node` v0.7.0 changes (0xPolygon#146)

* Update DS Format (0xPolygonHermez#3608)

* protobuf datastream

* proto batch end (0xPolygonHermez#3612)

* fix genesis DS (0xPolygonHermez#3615)

* Fix DSSendL2Block batch number (0xPolygonHermez#3617)

* Fix DSSendL2Block batch number

* latest proto (0xPolygonHermez#3620)

* Fix DSSendBatchEnd (0xPolygonHermez#3621)

* add TxFeeCap config (0xPolygonHermez#3611)

* Add delay when getting storedFlushId from the executor/hashdb (0xPolygonHermez#3625)

* Add sleep delay when getting storedFlushId from the executor/hashdb

* update config doc

* Fix use of L2coinbase configured in sequencesender.L2Coinbase parameter (0xPolygonHermez#3642)

* fix use l2coinbase configured in sequencesender.L2Coinbase parameter

* update doc

* Feature/3640 synchronizer choose to sync from l2 (0xPolygonHermez#3641)

* 0xPolygonHermez#3640. New Param Synchronizer.L2Synchronization.Enable to choose if sync from L2

* change synchronization config params 'Enable' to 'Enabled' (0xPolygonHermez#3656)

* change 'Enable' to 'Enabled' on sync config and changed comments

* Cherry-pick 0xPolygonHermez#3650: Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3654)

* Do fatal when datastream channel is full (workaround to fix datastream blocking issue) (0xPolygonHermez#3650)

* Do fatal when datastream channel is full (this will restart sequencer automatically)

* update datastream library (more ds-debug logs)

* fix decrease DataToStreamChannelCount

* add optimistic gas computation while estimating gas (0xPolygonHermez#3653)

* Use Eth block hash for l2 blocks in data stream (0xPolygonHermez#3661)

* Use Eth block hash for l2 blocks in data stream

* handle minTimestamp

* empty imStateRoot (0xPolygonHermez#3663)

* empty imStateRoot

* fix comment

* Cherry-pick 0xPolygonHermez#3659,0xPolygonHermez#3662: Remove sync with virtual state (synchronizer). Add L1 block confirmations (0xPolygonHermez#3666)

* Remove sync with virtual state (synchronizer). Add L1 block confirmat… (0xPolygonHermez#3659)

* Remove sync with virtual state (synchronizer). Add L1 block confirmations to consider sequence final

* fix get monitored tx receipt

* update doc

* Skip wait L1 block confirmations after restart (0xPolygonHermez#3662)

* skip wait L1 block confirmations after restart

* skip checking last batch sequenced in SC after restart

* set default value of SequenceL1BlockConfirmations to 32

* set default value of SequenceL1BlockConfirmations to 2 for debug/test

* fix config_test

* fix doc

* remove db tx from RPC (0xPolygonHermez#3648) (0xPolygonHermez#3683)

* remove synchronizer dependency from eth tx manager to confirm monitored tx (0xPolygonHermez#3658) (0xPolygonHermez#3677)

* Cherry-pick 0xPolygonHermez#3669: Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3690)

* Add WriteTimeout config parameter to StreamServer (0xPolygonHermez#3669)

* Add WriteTimeout config parameter to StreamServer. Update DS library

* update doc

* update default value for StreamServer.WriteTimeout config parameter. Increase buffer for datastream channel

* fix doc

* fix config test

* fix doc

* change imstateroot handling in DS (0xPolygonHermez#3698)

* change imstateroot handling in DS

* Fix tests

* Generate node config doc

* Update the diff

---------

Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com>
Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com>
Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com>

* Added Polygon R&D Link (0xPolygon#147)

---------

Co-authored-by: Daniel Jones <djones@polygon.technology>
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com>
Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com>
Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com>
Co-authored-by: Daniel Jones <105369507+djpolygon@users.noreply.github.com>
Co-authored-by: AMAN PANDEY <34401078+johnsoncarl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC seems to be keeping db connections open and getting stuck
2 participants