Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork 7 #325

Merged
merged 178 commits into from
Feb 2, 2024
Merged

fork 7 #325

merged 178 commits into from
Feb 2, 2024

Conversation

krlosMata
Copy link
Contributor

  • fork 7 from develop to main

krlosMata and others added 30 commits October 31, 2023 10:27
Set l2 tx hash computing at rlp parsing

Fix counters + counter tests

Fix log index

add pairings

add modexp

fixes & updates forkid6

update tests zkasm & helpers

Cleaning the repo

Fixing tests

Minor refactor and removing unnecessary zkasm files

Cleaning the repo

Removing some comments and moving unused files

Big refactor of pairings

Test passing now with a minor refactor

Test refactor and module tree fixed

Finished cleaning the pairing repo. Unused helpers removed

Finished cleaning the modexp repo

Setting the new number of chunks limit based on the gas limit

Reorganization and optimizations

fix modexp

add tool labels

last fixes & comments

fix mulArith

fix imports

update package

update package

update GHA

fix modexp gas

fix outofgas modexp & delete helpers

update package

Optimizations and code clarifications

Splitting the main operations in modexp and starting to perform tests...

Bug in long divison fixed

Fixing soundness errors in Fp arithemtic

Modexp-op1 test generator

update GHA fork-etrog

fix selector

add first counters modexp

Uncovered paths fixed

Some minor optimizations

Almost all counters added. Some major optimizations.

Ended the expected optimizations

update pre-modexp counters

Modexp counters done

Fixing minor typos and uncommenting the counters
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3 Security Hotspots

See analysis details on SonarCloud

Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@laisolizq laisolizq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit db1c8a1 into main Feb 2, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants