Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth claim nonce passed as parameter, default value if left blank #399

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

plusema86
Copy link
Contributor

No description provided.

@plusema86 plusema86 requested a review from 5eeman April 19, 2024 10:52
Copy link

gitguardian bot commented Apr 19, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5525172 Triggered Generic High Entropy Secret aae4b20 lib/constants.dart View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (3471b60) to head (fc7b012).

Files Patch % Lines
...ta_sources/lib_pidcore_credential_data_source.dart 0.00% 3 Missing ⚠️
...dential/libs/polygonidcore/pidcore_credential.dart 0.00% 2 Missing ⚠️
...ial/data/data_sources/local_claim_data_source.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #399      +/-   ##
===========================================
- Coverage    22.60%   22.59%   -0.01%     
===========================================
  Files          314      314              
  Lines         8768     8771       +3     
===========================================
  Hits          1982     1982              
- Misses        6786     6789       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@5eeman 5eeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plusema86 plusema86 merged commit a1489de into develop Apr 22, 2024
2 checks passed
@plusema86 plusema86 deleted the feature/auth-claim-nonce-default-value branch April 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants