Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth claim nonce passed as parameter, default value if left blank #399

Merged
merged 4 commits into from
Apr 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitguardian.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
version: 2

secret:
ignored_paths:
- 'lib/constants.dart'
- .gitignore
- '**/README.md'
1 change: 1 addition & 0 deletions lib/constants.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const AUTH_CLAIM_SCHEMA = "cca3371a6cb1b715004407e325bd993c";
const API_VERSION = 'v1';
const CHANNEL_NAME = 'technology.polygon.polygonid_flutter_sdk';
const DEFAULT_AUTH_CLAIM_NONCE = '15930428023331155902';

/// Database
const databaseName = "polygonIdSdk.db";
Original file line number Diff line number Diff line change
@@ -17,13 +17,19 @@ class LibPolygonIdCoreCredentialDataSource {
required String schema,
required String nonce,
required List<String> publicKey,
Map<String, dynamic> additionalInputParam = const {},
}) {
String input = jsonEncode({
"schema": schema, //"ca938857241db9451ea329256b9c06e5",
"nonce": nonce, //"15930428023331155902",
Map<String, dynamic> inputParam = {
"schema": schema,
"nonce": nonce,
"indexSlotA": publicKey[0],
"indexSlotB": publicKey[1],
});
};

//merge additionInputParam with inputParam removing duplicates
Map<String, dynamic> inputMerged = {...inputParam, ...additionalInputParam};

String input = jsonEncode(inputMerged);

String output = _polygonIdCoreCredential.createClaim(input);

6 changes: 4 additions & 2 deletions lib/credential/data/data_sources/local_claim_data_source.dart
Original file line number Diff line number Diff line change
@@ -8,9 +8,11 @@ class LocalClaimDataSource {

LocalClaimDataSource(this._libPolygonIdCoreCredentialDataSource);

Future<List<String>> getAuthClaim({required List<String> publicKey}) {
Future<List<String>> getAuthClaim({
required List<String> publicKey,
String authClaimNonce = DEFAULT_AUTH_CLAIM_NONCE,
}) {
String authClaimSchema = AUTH_CLAIM_SCHEMA;
String authClaimNonce = "15930428023331155902";
String authClaim = _libPolygonIdCoreCredentialDataSource.issueClaim(
schema: authClaimSchema,
nonce: authClaimNonce,
6 changes: 5 additions & 1 deletion lib/credential/libs/polygonidcore/pidcore_credential.dart
Original file line number Diff line number Diff line change
@@ -19,7 +19,11 @@ class PolygonIdCoreCredential extends PolygonIdCore {
int res = PolygonIdCore.nativePolygonIdCoreLib
.PLGNCreateClaim(response, in1, status);
if (res == 0) {
consumeStatus(status, "");
String? consumedStatus = consumeStatus(status, "");
if (consumedStatus != null) {
malloc.free(status);
return consumedStatus;
}
}
String result = "";
ffi.Pointer<ffi.Char> jsonResponse = response.value;
4 changes: 3 additions & 1 deletion lib/iden3comm/authenticate.dart
Original file line number Diff line number Diff line change
@@ -120,6 +120,7 @@ class Authenticate {
required String? pushToken,
String? challenge,
final Map<String, dynamic>? transactionData,
String authClaimNonce = DEFAULT_AUTH_CLAIM_NONCE,
}) async {
try {
List<Iden3commProofEntity> proofs = [];
@@ -187,6 +188,7 @@ class Authenticate {
chain: chain,
privateKey: privateKey,
privateKeyBytes: privateKeyBytes,
authClaimNonce: authClaimNonce,
);

// if there are proof requests and claims and they are the same length
@@ -1198,6 +1200,7 @@ class Authenticate {
required EnvEntity env,
required ChainConfigEntity chain,
required Uint8List privateKeyBytes,
required String authClaimNonce,
}) async {
List<String>? authClaim;
MTProofEntity? incProof;
@@ -1211,7 +1214,6 @@ class Authenticate {
List<String> publicKey = BjjWallet(privateKeyBytes).publicKey;

String authClaimSchema = AUTH_CLAIM_SCHEMA;
String authClaimNonce = "15930428023331155902";
String issuedAuthClaim = libPolygonIdCredential.issueClaim(
schema: authClaimSchema,
nonce: authClaimNonce,
12 changes: 6 additions & 6 deletions lib/sdk/di/injector.config.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.