Reduce state trie size for dummy payloads #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
added
performance
muursh
approved these changes
Mar 6, 2024
BGluth
pushed a commit
that referenced
this pull request
Jun 17, 2024
* feat: add block interval * fix: follow from loop * feat: add block hash parsing for interval * fix: proving logic * fix: typos * fix: review * fix: doc tests * feat: add block time cli argument * fix: interval display * feat: add from string for block interval * fix: remove block interval single variant * feat: implement concurrent block proving #88 #89 (#96) * feat: implement concurrent block proving #88 #89 * Update prover/src/lib.rs Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com> * fix suggestion * Fix duplicated import when #[cfg(feature = "test_only")] --------- Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com> Co-authored-by: Marko Atanasievski <markoatana@gmail.com> * fix: block interval fmt * fix: make parsing functions private * fix: use futures iterator instead of tokio-stream * fix: use anyhow error instead of block interval error --------- Co-authored-by: Zach Brown <zach@zb.dev> Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly minor, but while debugging I realized that we should (as the comment specifies) pass an empty iterator instead of
once.This saves a few thousand cycles on dummy payloads (tested against John's test chain).