Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation inputs logging pre-transaction execution #89

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Mar 6, 2024

Yet another tiny bug fix post #56.
CPU simulation displays default values in Debug mode, because we initialize the interpreter with empty inputs, before setting them during preinitialization.

DEBUG evm_arithmetization::generation::state: Input signed_txn: None    
DEBUG evm_arithmetization::generation::state: Input state_trie: HashedPartialTrie { node: Empty, hash: RwLock { data: None } }    
DEBUG evm_arithmetization::generation::state: Input transactions_trie: HashedPartialTrie { node: Empty, hash: RwLock { data: None } }    
DEBUG evm_arithmetization::generation::state: Input receipts_trie: HashedPartialTrie { node: Empty, hash: RwLock { data: None } }    
DEBUG evm_arithmetization::generation::state: Input storage_tries: []    
DEBUG evm_arithmetization::generation::state: Input contract_code: {}    

This PR fixes it.

@Nashtare Nashtare added bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Mar 6, 2024
@Nashtare Nashtare requested a review from LindaGuiga March 6, 2024 07:56
@Nashtare Nashtare self-assigned this Mar 6, 2024
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashtare Nashtare merged commit 65ccc3a into main Mar 6, 2024
5 checks passed
@Nashtare Nashtare deleted the yet-another-log-fix branch March 6, 2024 08:33
BGluth pushed a commit that referenced this pull request Jun 17, 2024
* feat: add block interval

* fix: follow from loop

* feat: add block hash parsing for interval

* fix: proving logic

* fix: typos

* fix: review

* fix: doc tests

* feat: add block time cli argument

* fix: interval display

* feat: add from string for block interval

* fix: remove block interval single variant

* feat: implement concurrent block proving #88 #89 (#96)

* feat: implement concurrent block proving #88 #89

* Update prover/src/lib.rs

Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com>

* fix suggestion

* Fix duplicated import when #[cfg(feature = "test_only")]

---------

Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com>
Co-authored-by: Marko Atanasievski <markoatana@gmail.com>

* fix: block interval fmt

* fix: make parsing functions private

* fix: use futures iterator instead of tokio-stream

* fix: use anyhow error instead of block interval error

---------

Co-authored-by: Zach Brown <zach@zb.dev>
Co-authored-by: 0xaatif <169152398+0xaatif@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants