This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Increase timeout for conversion tests #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
reviewed
Feb 12, 2020
| @@ -42,7 +42,7 @@ test-go: test-go-parallel test-go-serial | |||
|
|
|||
| .PHONY: test-go-parallel | |||
| test-go-parallel: | |||
| go test ./... -race -timeout 30s | |||
| go test ./... -race -timeout 180s | |||
There was a problem hiding this comment.
Do we want to increase the lifetime of all of these tests? In my convertConfig tests PR, I added a new command to the Makefile. You might check that out and see which you prefer.
There was a problem hiding this comment.
It shouldn't really matter much, but I just approved #703 so let's go with that instead. I'll close this one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests often fail on the first run because it takes a long time to install some dependencies. The exact time depends on your internet speed and other factors, but 180s seems safe.