Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Increase timeout for conversion tests #709

Closed
wants to merge 1 commit into from
Closed

Increase timeout for conversion tests #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ test-go: test-go-parallel test-go-serial

.PHONY: test-go-parallel
test-go-parallel:
go test ./... -race -timeout 30s
go test ./... -race -timeout 180s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to increase the lifetime of all of these tests? In my convertConfig tests PR, I added a new command to the Makefile. You might check that out and see which you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't really matter much, but I just approved #703 so let's go with that instead. I'll close this one.


.PHONY: test-go-serial
test-go-serial:
Expand Down
2 changes: 1 addition & 1 deletion browser/go/conversion-test/conversion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var testCases []string
func TestBrowserConversions(t *testing.T) {
// Declare a context that will be used for all child processes, servers, and
// other goroutines.
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
ctx, cancel := context.WithTimeout(context.Background(), 175*time.Second)
ctx, _ = chromedp.NewContext(ctx, chromedp.WithErrorf(t.Errorf))
defer cancel()

Expand Down