-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency for get_client_ip #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 95.68% 95.73% +0.04%
==========================================
Files 20 20
Lines 649 656 +7
==========================================
+ Hits 621 628 +7
Misses 28 28
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 49d51cd into 8521a7d - view on LGTM.com fixed alerts:
|
49d51cd
to
1b8a3d5
Compare
This pull request fixes 1 alert when merging 1b8a3d5 into 8521a7d - view on LGTM.com fixed alerts:
|
7c39162
to
97f4100
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.65%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
This pull request fixes 1 alert when merging 97f4100 into 8521a7d - view on LGTM.com fixed alerts:
|
Hey, I just made a Pull Request!
Description
This PR removes dependency from drf-addons for
get_client_ip
.Motivation and Context
Have you tested this? If so, how?
Checklist for PR author(s)
interrogate drf_user
(I mean, we should set a good example 😄).README.md
.README.md
anddocs/index.rst
for any new changes.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in the project's__init__.py
file.Release note