Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

warning: `if` chain can be rewritten with `match` --> vector_utils/src/lib.rs:138:9 | 138 | / if x[i] < y[j] { 139 | | i += 1; 140 | | } else if y[j] < x[i] { 141 | | j += 1; 142 | | } else { 143 | | return true; 144 | | } | |_________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain = note: `#[warn(clippy::comparison_chain)]` on by default

warning: `if` chain can be rewritten with `match` --> vector_utils/src/lib.rs:158:9 | 158 | / if x[i] < y[j] { 159 | | i += 1; 160 | | } else if y[j] < x[i] { 161 | | j += 1; ... | 165 | | j += 1; 166 | | } | |_________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain

warning: `if` chain can be rewritten with `match` --> vector_utils/src/lib.rs:177:9 | 177 | / if x[ix] < y[iy] { 178 | | ix += 1; 179 | | } else if y[iy] < x[ix] { 180 | | iy += 1; ... | 184 | | iy += 1; 185 | | } | |_________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain

warning: this function has too many arguments (12/7) --> dna/src/lib.rs:129:1 | 129 | / pub fn get_thermodynamic_parameters_dna( 130 | | dh: &mut Vec<Vec<f64>>, 131 | | ds: &mut Vec<Vec<f64>>, 132 | | dg: &mut Vec<Vec<f64>>, ... | 141 | | dg_symmetry_correction: &mut f64, 142 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: `if` chain can be rewritten with `match` --> tables/src/lib.rs:255:17 | 255 | / if have > need { 256 | | if debug_print { 257 | | println!( 258 | | "adding {} spaces to right of row {} col {}", ... | 272 | | ext[k - 1] += need - have; 273 | | } | |_________________^ | = help: consider rewriting the `if` chain to use `cmp` and `match` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain = note: `#[warn(clippy::comparison_chain)]` on by default

warning: this function has too many arguments (15/7) --> vdj_ann/src/annotate.rs:3288:5 | 3288 | / pub fn from_annotate_seq( 3289 | | b: &DnaString, // the contig 3290 | | q: &[u8], // qual scores for the contig 3291 | | tigname: &str, // name of the contig ... | 3303 | | jsupp: Option<JunctionSupport>, // num reads, umis supporting junction 3304 | | ) -> ContigAnnotation { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: this function has too many arguments (12/7) --> vdj_ann/src/annotate.rs:3415:5 | 3415 | / pub fn from_seq( 3416 | | b: &DnaString, // the contig 3417 | | q: &[u8], // qual scores for the contig 3418 | | tigname: &str, // name of the contig ... | 3427 | | jsupp: Option<JunctionSupport>, // num reads, umis supporting junction 3428 | | ) -> ContigAnnotation { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> vdj_ann_ref/src/lib.rs:71:1 | 71 | / pub fn make_vdj_ref_data( 72 | | refdata: &mut RefData, 73 | | imgt: bool, 74 | | species: &str, ... | 79 | | mouse_supp_ref: &str, 80 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: this function has too many arguments (11/7) --> vdj_ann_ref/src/bin/build_vdj_ref.rs:178:1 | 178 | / fn add_gene<R: Write>( 179 | | out: &mut R, 180 | | gene: &str, 181 | | record: &mut usize, ... | 189 | | source: &str, 190 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default