Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case where:
This provides savings so that the lookup within the hash function is basically the same cost as a u64 regardless of the true size of the key input. Obviously the hash still has to be done somewhere, so it's not totally free but as mentioned the savings grow the more hash functions I need to interrogate and it lets me use a faster xxh3 hash.
I tried to keep the identical hash results if you use anything other than the new ExternallyHashed type while simultaneously carving out a fast path for it to shine (I've also in theory fast-pathed construction/lookups for integer keys where we can skip constructing the WyHash state object but I didn't bother benchmarking the actual improvement there).