Feature activation: Alert when a new reindex needs to happen #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahmon
reviewed
Nov 15, 2021
Rahmon
reviewed
Nov 15, 2021
|
|
||
| if ( ! $this->is_active() && $this->requires_install_reindex && $can_save ) { | ||
| $requirements_status->message = (array) $requirements_status->message; | ||
| $requirements_status->message[] = __( 'A new reindex will start when you activate this feature.', 'elasticpress' ); |
There was a problem hiding this comment.
Just wondering, should we put this message at the top?
There was a problem hiding this comment.
That is a good point @Rahmon. I think all messages have the same importance, so IDK if we want to come up with a prioritization thing but we can bring that up during our internal sync.
Also, we need to change that __() call to use esc_html__()
|
Closing this in favor of #2491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently, users don't have much info that a new reindex will start when a certain feature is activated. This PR adds a notice based on the Feature
requires_install_reindexattribute.Alternate Designs
Perhaps we could place the message somewhere else.
Benefits
Users won't start a reindex without notice.
Possible Drawbacks
n/a
Verification Process
Created the code and checked in the Features Screen.
Checklist:
Applicable Issues
Closes #1932
Changelog Entry
Adds a new notice to features that need a resync after activation.