Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1932 #2491

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Feature/1932 #2491

merged 4 commits into from
Dec 6, 2021

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Dec 6, 2021

Description of the Change

Display a warning notice when choosing to enable a feature when that feature requires reindexing. Then, when the user clicks to save the settings, warn the user again and ask them to confirm that a reindex will occur.

Benefits

Lets a user know, and asks them to confirm, that a lengthy reindex could occur when enabling a feature that requires a reindex.

Verification Process

  1. Go to a setting that requires reindexing. Select "Enabled" a warning message should appear.
  2. Click to disable the setting, the warning message should disappear.
  3. Click to enable it again and the warning will reappear.
  4. Click save, a browser confirm dialog should ask the for confirmation.
  5. Press cancel, setting should not save.
  6. Click save again, and OK in the confirm dialog. Settings will save and you will be redirected to the sync page.
  7. Go back to Features, choose to disable the feature and save. There should be no warning or confirmation. No redirect should occur.
  8. After saving is complete, click to Enable the feature. The warning should appear again.
  9. Click to save, the confirmation should appear again.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Resolves #1932.

Changelog Entry

  • Display a notice that content will be reindexed when enabling a feature that requires it.

@JakePT JakePT self-assigned this Dec 6, 2021
@JakePT JakePT changed the base branch from develop to 4.x.x December 6, 2021 14:30
@felipeelia felipeelia self-assigned this Dec 6, 2021
@felipeelia felipeelia added this to the 4.0.0 (beta 1) milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notify of required resync while editing feature settings
2 participants